service: Regenerate gRPC stubs and update check_nims.yml to check for out-of-date gRPC stubs #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
pbirkhol-ni and
dixonjoel
as code owners
bkeryan
force-pushed
the
users/bkeryan/update-stubs
branch
2 times, most recently
from
a8d096e to
9afdbee
Compare
bkeryan
force-pushed
the
users/bkeryan/update-stubs
branch
from
9afdbee to
1f9afe1
Compare
dixonjoel
approved these changes
Dec 13, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Regenerate gRPC stubs.
Update
check_nims.ymlto regenerate gRPC stubs and check whether they are out-of-date.Why should this Pull Request be merged?
Reduce diff noise when modifying test protos.
Ensure that we update codegen when upgrading grpcio-tools, mypy-protobuf, etc.
What testing has been done?
PR build