fix: use os.path to avoid os errors for invalid file paths #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaseelan-james
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
vigkre
approved these changes
Dec 29, 2023
mshafer-NI
reviewed
Jan 2, 2024
dixonjoel
approved these changes
Jan 2, 2024
bkeryan
requested changes
Jan 4, 2024
jayaseelan-james
commented
Jan 5, 2024
bkeryan
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Use os.path.exists(path) instead of
Path.exists()to swallow OS errors for invalid file paths for older Python versions. AB#2606153Why should this Pull Request be merged?
When the
.envfile isn't present in any of the measurement.py parent directories and if TestStand adaptors use any Python version <3.8.10 or <3.9.5, an OSError is thrown for invalid file paths. Usingos.path.exists(path)resolves this error.What testing has been done?
Ran mypy and manually ran the "nidcpower_source_dc_voltage" example's sequence file in TestStand 2021 SP1 with Python versions 3.8.9, 3.8.10, 3.9.4, 3.9.5, 3.9.13 and 3.10.11.