Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt : Display proper error message when update pin map step is… #719

Merged

Conversation

prat-mahendran
Copy link
Contributor

@prat-mahendran prat-mahendran commented May 8, 2024

What does this Pull Request accomplish?

  • We use the self._sequence_context.Execution.RunTimeVariables.Exists method call to determine if the field PinMapId exists in TestStand. It returns a Boolean value. If the field is not available, we throw a runtime error; if it is available, we proceed and return its value.

Why should this Pull Request be merged?

  • This presents a user-friendly error message when a user overlooks adding an "Update Pin Map" step to their sequencer, ensuring easy understanding of the issue.

Before

before_python

After

after

What testing has been done?

Manually verified the example execution.

Copy link

github-actions bot commented May 8, 2024

Test Results

    30 files  ±0      30 suites  ±0   49m 23s ⏱️ -50s
   653 tests ±0     653 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 210 runs  ±0  15 150 ✅ ±0  1 060 💤 ±0  0 ❌ ±0 

Results for commit 797e76f. ± Comparison against base commit 55986f7.

♻️ This comment has been updated with latest results.

@prat-mahendran prat-mahendran changed the title Tech Debt : Display proper error message when update pin map step is… [Draft] [Do Not Review] Tech Debt : Display proper error message when update pin map step is… May 8, 2024
Copy link
Contributor

@jayaseelan-james jayaseelan-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure to update the changes in all of its occurrences and update the PR title and description respectively.

@prat-mahendran prat-mahendran changed the title [Draft] [Do Not Review] Tech Debt : Display proper error message when update pin map step is… Tech Debt : Display proper error message when update pin map step is… May 9, 2024
Copy link
Collaborator

@dixonjoel dixonjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions once the checks are all passing.

Copy link

@SowmyaRavee SowmyaRavee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint error and update the variable name

@prat-mahendran prat-mahendran requested a review from bkeryan May 13, 2024 04:06
@prat-mahendran prat-mahendran merged commit 437d4a5 into main May 14, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/Prathana/Add_error_message_update_pinMap_missing branch June 5, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants