Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Add dependency to Measurement Plug-In Client #876

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal commented Sep 6, 2024

What does this Pull Request accomplish?

  • Add "black" to dependency in Measurement Plug-In Client.

Why should this Pull Request be merged?

  • This implementation contains the addition of black as package dependency, as fresh machine installation requires black.

What testing has been done?

  • Existing automation tests passed.

Copy link

github-actions bot commented Sep 6, 2024

Test Results

    30 files  ±0      30 suites  ±0   41m 5s ⏱️ + 1m 46s
   651 tests ±0     651 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 130 runs  ±0  15 060 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit 5dbb07d. ± Comparison against base commit 5974af6.

Copy link
Contributor

@jayaseelan-james jayaseelan-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing dependency.

Please update the description explaining why black is required as a dependency.

@dixonjoel
Copy link
Collaborator

Added missing dependency.

Please update the description explaining why black is required as a dependency.

I don't know why this is needed. We already have 'black' in the poetry.lock. Do you need a specific version for some reason?

@Jotheeswaran-Nandagopal
Copy link
Contributor Author

Jotheeswaran-Nandagopal commented Sep 6, 2024

Added missing dependency.

Please update the description explaining why black is required as a dependency.

I don't know why this is needed. We already have 'black' in the poetry.lock. Do you need a specific version for some reason?

Added missing dependency.

Please update the description explaining why black is required as a dependency.

I don't know why this is needed. We already have 'black' in the poetry.lock. Do you need a specific version for some reason?

Without adding the "black" in [tool.poetry.dependencies], fresh machine testing throws error with black package is missing. So, adding "black" in dependencies to fix this.

@Jotheeswaran-Nandagopal
Copy link
Contributor Author

Jotheeswaran-Nandagopal commented Sep 10, 2024

Added missing dependency.

Please update the description explaining why black is required as a dependency.

I don't know why this is needed. We already have 'black' in the poetry.lock. Do you need a specific version for some reason?

Added missing dependency.

Please update the description explaining why black is required as a dependency.

I don't know why this is needed. We already have 'black' in the poetry.lock. Do you need a specific version for some reason?

Without adding the "black" in [tool.poetry.dependencies], fresh machine testing throws error with black package is missing. So, adding "black" in dependencies to fix this.

@dixonjoel Currently, black is in dev dependency, but we are using black in the Measurement Plug-In Client generator for formatting the generated code, which requires black to be added in package dependency. So, I have updated the pyproject.toml by adding black.

@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal merged commit 00d8103 into main Sep 10, 2024
17 checks passed
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal deleted the users/jothees/pyproject-update-black branch September 10, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants