Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case to check mypy error in generated client and fix existing mypy errors #914

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Add test case to check mypy error in generated client and fix existing mypy errors #914

merged 7 commits into from
Sep 24, 2024

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal commented Sep 23, 2024 •
edited
Loading

What does this Pull Request accomplish?

  • Add test case for checking the mypy issues in the generated Measurement Plug-In Client.
  • Fix the existing type hints and mypy issues in Mako template.

Why should this Pull Request be merged?

  • Fix the existing type hints in the mako template.
  • Add mypy check as a test case to check the type hints in the generated Measurement Plug-In Client.

What testing has been done?

  • Done manual testing.
  • Existing and new automation tests passed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Test Results

    40 files  ± 0      40 suites  ±0   55m 32s ⏱️ + 3m 57s
   693 tests + 1     693 ✅ + 1      0 💤 ±0  0 ❌ ±0 
16 830 runs  +10  15 760 ✅ +10  1 070 💤 ±0  0 ❌ ±0 

Results for commit 72987a1. ± Comparison against base commit 868b6db.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan mentioned this pull request Sep 23, 2024
Closed
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal merged commit 58ced1a into main Sep 24, 2024
17 checks passed
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal deleted the users/jothees/fix-mypy-issues branch September 24, 2024 17:23
Jotheeswaran-Nandagopal added a commit that referenced this pull request Sep 24, 2024
@Jotheeswaran-Nandagopal
Add test case to check mypy error in generated client and fix existin…
87c66a1 
…g mypy errors (#914)

* fix: add test case to run mypy in the generated client

(cherry picked from commit 58ced1a)
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal mentioned this pull request Sep 24, 2024
Merged
1 task
bkeryan
bkeryan reviewed Sep 24, 2024
View reviewed changes
...st_assets/example_renders/measurement_plugin_client/non_streaming_data_measurement_client.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These type hints are still wrong. They don't match the runtime type. None of the list outputs are actually lists.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#930

bkeryan pushed a commit that referenced this pull request Sep 24, 2024
@Jotheeswaran-Nandagopal
[releases/2.1] Cherry-pick: Add test case to check mypy error in gene…
16879f6 
…rated client and fix existing mypy errors (#929)

Add test case to check mypy error in generated client and fix existing mypy errors (#914)

* fix: add test case to run mypy in the generated client

(cherry picked from commit 58ced1a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeryan bkeryan bkeryan approved these changes

@dixonjoel dixonjoel dixonjoel approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

@Avinash2Suresh Avinash2Suresh Awaiting requested review from Avinash2Suresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jotheeswaran-Nandagopal @bkeryan @dixonjoel