Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for unregistering callbacks #15

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Fix for unregistering callbacks #15

merged 1 commit into from
Jul 10, 2017

Conversation

CarlAndersson
Copy link
Contributor

A possible fix to enable unregistering of callback functions. Only tested with 'register_every_n_samples_acquired_into_buffer_event', but should work with all versions.

@CarlAndersson
Fix for unregistering callbacks
38f9f09 
A possible fix to enable unregistering of callback functions. Only tested with 'register_every_n_samples_acquired_into_buffer_event', but should work with all versions.
@CarlAndersson CarlAndersson mentioned this pull request Jul 6, 2017
Closed
neilvana
neilvana approved these changes Jul 7, 2017
View reviewed changes
Copy link
Collaborator

@neilvana neilvana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix. After @brianlee1200 merges these changes he plans to fix a few more issues, perhaps add a few auto tests, do a little testing and then we'll try to get a new minor release posted to Pypi.

@neilvana neilvana assigned Wondernutz and neilvana and unassigned Wondernutz and neilvana Jul 7, 2017
@Wondernutz Wondernutz merged commit 552b12a into ni:master Jul 10, 2017
Wondernutz added a commit that referenced this pull request Jul 10, 2017
@Wondernutz
Merge Pull Request 15 and Fix Issues 11, 12, 13
e23f517 
<rev> Merging pull request - "Fix for unregistering callbacks"
#15

<rev> Fixing issue - "Should `_import_lib` error for unsupported
platforms?"
#13

<rev> Fixing issue - "Cannot catch load/version issues with public API"
#12

<rev> Fixing issue - "CONTRIBUTING.rst link to Issues is broken"
#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilvana neilvana neilvana approved these changes

Assignees

@Wondernutz Wondernutz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlAndersson @neilvana @Wondernutz