Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize for happy path #179

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Optimize for happy path #179

merged 1 commit into from
Jun 24, 2022

Conversation

zariiii9003
Copy link
Contributor

@zariiii9003 zariiii9003 commented Jun 24, 2022 •
edited by zhindes
Loading

Return immediately from check_for_error on success.

zhindes
zhindes approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thanks!

@zhindes zhindes merged commit 392157c into ni:master Jun 24, 2022
@zariiii9003
Copy link
Contributor Author

zariiii9003 commented Aug 13, 2022 •
edited
Loading

@zhindes Could you upload a new release to PyPI?

@zhindes
Copy link
Collaborator

zhindes commented Aug 15, 2022

@zariiii9003 - yep, will do today.

@zhindes
Copy link
Collaborator

zhindes commented Aug 22, 2022

@zariiii9003 - sorry for the delay - https://pypi.org/project/nidaqmx/0.6.4/

@zariiii9003
Copy link
Contributor Author

@zhindes No worries, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhindes zhindes zhindes approved these changes

@maxxboehme maxxboehme Awaiting requested review from maxxboehme maxxboehme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zariiii9003 @zhindes