-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issues causing errors in test cases using real devices #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested changes
May 4, 2023
bkeryan
requested changes
May 4, 2023
Updated results. (This included the direction tweak I suggested, but it probably doesn't matter.)
|
bkeryan
requested changes
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I think we should use the parameter direction field to decide which flags to use.
Thank you Brad for testing the test cases which we couldn't cover. |
bkeryan
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Fixes the errors in tests using real device. The issues are
read_raw
.FillMode
passed to functionwrite_digital_scalar_u32
.read_array/write_array
ofread_digital_lines/write_digital_lines
tobool
since it is expected one.power_up_state
by value in caller since it is returned by value from the interpreter.Why should the PR be merged?
This PR fixes the errors in the testcases mentioned in the Task 2382630: Fix failure test cases using hardware
What testing has been done?
Ensured errors are not thrown while running these tests but tests are not run using real device.