Allow final
structs & classes serialization
#149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I can't serialize a class
T
marked asfinal
because thedetail::has_memfn_serializer<>
metafunction relies on the following trick to detect the serialize function presence.I've updated the
tests/base/include/json_conformance.hpp
to addfinal
to the tested class in order to experience the limitation.This MR provides another implementation of the
detail::has_memfn_serializer<>
metafunction, but it ignores the return type of theT::serialize()
function. I'm not comfortable with this choice because in your implementation, my understanding is that you ignore the return type as well, but it seems there is some facility to check it (i.e.return_value_check
) ¯_(ツ)_/¯.Some tests are failing as well on my Fedora 39, and there are warnings.
Do you want me to do some cleaning ?