Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring trace_state code #2

Closed
wants to merge 4 commits into from
Closed

Refactoring trace_state code #2

wants to merge 4 commits into from

Conversation

nikhil1511
Copy link
Owner

@nikhil1511 nikhil1511 commented Mar 26, 2021 •
edited
Loading

Fixes #

Changes

  • Refactoring trace state changes to reuse some common functionality into baggage.
  • Extracted key value pair functions from trace_state into common place

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

madhusudanas
madhusudanas reviewed Mar 26, 2021
View reviewed changes
@nikhil1511 nikhil1511 mentioned this pull request Mar 26, 2021
Closed
@nikhil1511
Copy link
Owner Author

PR merged in upstream. Closing it.

@nikhil1511 nikhil1511 closed this Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhusudanas madhusudanas madhusudanas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhil1511 @madhusudanas