-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove login password from sessions. #4455
Merged
nilsteampassnet
merged 10 commits into
nilsteampassnet:master
from
corentin-soriano:remove_session_password
Nov 14, 2024
Merged
Remove login password from sessions. #4455
nilsteampassnet
merged 10 commits into
nilsteampassnet:master
from
corentin-soriano:remove_session_password
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
corentin-soriano
commented
Nov 12, 2024
•
edited
Loading
edited
- Remove login password from session.
- Validate user password before keys reencryption (will probably fix After update from version 3.1.2.29 to 3.1.2.139 I have two problems #4407).
- Fix issue on LDAP password change (hash was not updated in database).
- Remove debug log which can leak user password in php logs.
- When updating the key, reset the last download timestamp to notify the user that he need to download them again.
e697677
to
f6d64c1
Compare
1462e08
to
cb3471a
Compare
a139f81
to
ac3cd68
Compare
ac3cd68
to
e92614d
Compare
e92614d
to
28aeae9
Compare
nilsteampassnet
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.