Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove login password from sessions. #4455

Merged

Conversation

corentin-soriano
Copy link
Contributor

@corentin-soriano corentin-soriano commented Nov 12, 2024

  • Remove login password from session.
  • Validate user password before keys reencryption (will probably fix After update from version 3.1.2.29 to 3.1.2.139 I have two problems #4407).
  • Fix issue on LDAP password change (hash was not updated in database).
  • Remove debug log which can leak user password in php logs.
  • When updating the key, reset the last download timestamp to notify the user that he need to download them again.

@corentin-soriano corentin-soriano force-pushed the remove_session_password branch 3 times, most recently from 1462e08 to cb3471a Compare November 13, 2024 13:59
@corentin-soriano corentin-soriano force-pushed the remove_session_password branch 2 times, most recently from a139f81 to ac3cd68 Compare November 14, 2024 08:48
@corentin-soriano corentin-soriano marked this pull request as ready for review November 14, 2024 15:56
Copy link
Owner

@nilsteampassnet nilsteampassnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved

@nilsteampassnet nilsteampassnet merged commit fae22cd into nilsteampassnet:master Nov 14, 2024
1 check failed
@corentin-soriano corentin-soriano deleted the remove_session_password branch November 25, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After update from version 3.1.2.29 to 3.1.2.139 I have two problems
2 participants