Code review #4469
Merged
Code review #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nilsteampassnet
commented
Nov 16, 2024
nilsteampassnet
commented
- background_tasks___userKeysCreation.php: comments translations ; Ignored an error in Scrutinizer
- task_maintenance_purge_old_files.php: Fixed an issue regarding folder ressource
- identify.php: Fixed Scrutinizer warning, missing variables initialization
- logs.datatables.php: fixed possible type concatenation
- tree.php: improved recursive tree function
- Removed some unused variables
- Added Scrutinizer ignore
- Reworked function storeUsersShareKey() based upon Scrutinizer findings
* Added Scrutinizer ignore * Reworked function storeUsersShareKey() based upon Scrutinizer findings
…nored an error in Scrutinizer * task_maintenance_purge_old_files.php: Fixed an issue regarding folder ressource * identify.php: Fixed Scrutinizer warning, missing variables initialization * logs.datatables.php: fixed possible type concatenation * tree.php: improved recursive tree function
corentin-soriano
suggested changes
Nov 16, 2024
corentin-soriano
suggested changes
Nov 16, 2024
| 'error' => true, | ||
| 'message' => $lang->get('error_bad_credentials'), | ||
| 'error' => false, | ||
| 'user_info' => $userADInfos |
There was a problem hiding this comment.
This is not necessarily a problem but I wonder what exactly $userADInfos contains.
There was a problem hiding this comment.
If I remember well, $userADInfos contains a set of LDAP user attributes such as DN, mail, givenname, etc.
corentin-soriano
suggested changes
Nov 21, 2024
* Fixed ordering not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.