Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for getpeereid(3) #1339

Closed
woodruffw opened this issue Nov 24, 2020 · 3 comments · Fixed by #1342
Closed

Support for getpeereid(3) #1339

woodruffw opened this issue Nov 24, 2020 · 3 comments · Fixed by #1342

Comments

@woodruffw
Copy link
Contributor

macOS and most of the BSDs have a getpeereid(3) library routine, which can be used to retrieve the effective UID and GID for a given Unix domain socket.

This roughly mirrors the functionality provided by getsockopt(2) + SO_PEERCRED on Linux (minus the PID), which the nix crate already supports.

I have the bandwidth and ability to implement this, if desired.
@valpackett
Copy link
Contributor

We'll need this in zbus, so you have a consumer already!

Side note, OpenBSD also supports SO_PEERCRED with minor differences (usage example); FreeBSD supports LOCAL_PEERCRED but gained the pid field very recently; NetBSD has LOCAL_PEEREID; Solaris/illumos(?) has getpeerucred. Would be nice to also get all these mechanisms in here eventually…

@woodruffw
Copy link
Contributor Author

Fantastic. I have rust-lang/rust#79387 pending on Rust itself to improve the nightly-only UCred API, which should eventually handle those minor differences on the BSDs as well. But yeah, it would certainly good to have them exposed independently in nix as well.

woodruffw added a commit to woodruffw-forks/nix that referenced this issue Nov 26, 2020
@woodruffw
unistd: Add getpeereid(3)
70cef81 
Closes nix-rust#1339.
@woodruffw woodruffw mentioned this issue Nov 26, 2020
Merged
@woodruffw
Copy link
Contributor Author

Okay, #1342 has the wrapper.

woodruffw added a commit to woodruffw-forks/nix that referenced this issue Nov 29, 2020
@woodruffw
unistd: Add getpeereid(3)
1299538 
Closes nix-rust#1339.
bors bot added a commit that referenced this issue Nov 29, 2020
@bors @woodruffw
Merge #1342
8e00776 
1342: feat(unistd): Add getpeereid(3) r=asomers a=woodruffw

`getpeereid(3)` is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (compare `getsockopt` + `SO_PEERCRED` on Linux, which `nix` already supports).

Closes #1339.

Co-authored-by: William Woodruff <william@yossarian.net>
woodruffw added a commit to woodruffw-forks/nix that referenced this issue Nov 29, 2020
@woodruffw
unistd: Add getpeereid(3)
2a498dd 
Closes nix-rust#1339.
woodruffw added a commit to woodruffw-forks/nix that referenced this issue Nov 29, 2020
@woodruffw
unistd: Add getpeereid(3)
354b3c6 
Closes nix-rust#1339.
woodruffw added a commit to woodruffw-forks/nix that referenced this issue Nov 29, 2020
@woodruffw
unistd: Add getpeereid(3)
000e671 
Closes nix-rust#1339.
bors bot added a commit that referenced this issue Dec 2, 2020
@bors @woodruffw
Merge #1342
bbe4318 
1342: feat(unistd): Add getpeereid(3) r=asomers a=woodruffw

`getpeereid(3)` is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (compare `getsockopt` + `SO_PEERCRED` on Linux, which `nix` already supports).

Closes #1339.

Co-authored-by: William Woodruff <william@yossarian.net>
bors bot added a commit that referenced this issue Dec 2, 2020
@bors @woodruffw
Merge #1342
d0278bd 
1342: feat(unistd): Add getpeereid(3) r=asomers a=woodruffw

`getpeereid(3)` is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (compare `getsockopt` + `SO_PEERCRED` on Linux, which `nix` already supports).

Closes #1339.

Co-authored-by: William Woodruff <william@yossarian.net>
woodruffw added a commit to woodruffw-forks/nix that referenced this issue Dec 8, 2020
@woodruffw
unistd: Add getpeereid(3)
8ca6e20 
Closes nix-rust#1339.
woodruffw added a commit to woodruffw-forks/nix that referenced this issue Dec 15, 2020
@woodruffw
unistd: Add getpeereid(3)
fff75b4 
Closes nix-rust#1339.
woodruffw added a commit to woodruffw-forks/nix that referenced this issue Dec 15, 2020
@woodruffw
unistd: Add getpeereid(3)
ae25804 
Closes nix-rust#1339.
bors bot added a commit that referenced this issue Dec 16, 2020
@bors @woodruffw
Merge #1342
eb4e312 
1342: feat(unistd): Add getpeereid(3) r=asomers a=woodruffw

`getpeereid(3)` is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (compare `getsockopt` + `SO_PEERCRED` on Linux, which `nix` already supports).

Closes #1339.

Co-authored-by: William Woodruff <william@yossarian.net>
woodruffw added a commit to woodruffw-forks/nix that referenced this issue Dec 19, 2020
@woodruffw
unistd: Add getpeereid(3)
e0b9eb5 
Closes nix-rust#1339.
bors bot added a commit that referenced this issue Dec 22, 2020
@bors @woodruffw
Merge #1342
8cff207 
1342: feat(unistd): Add getpeereid(3) r=asomers a=woodruffw

`getpeereid(3)` is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (compare `getsockopt` + `SO_PEERCRED` on Linux, which `nix` already supports).

Closes #1339.

Co-authored-by: William Woodruff <william@yossarian.net>
@bors bors bot closed this as completed in 7c3a353 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(unistd): Add getpeereid(3) woodruffw-forks/nix
2 participants
@valpackett @woodruffw