Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Fix examples and add @details #136

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Jan 6, 2025

Part of rOpenSci review. @njtierney, would you like to add any @details to tar_terra_sprc() and tar_terra_sds() explaining the problem they are solving? The reviewer noted we did a good job of this with tar_terra_rast(), but the explanation of the problem was missing from some other functions.

@Aariq
Copy link
Collaborator Author

Aariq commented Jan 17, 2025

Looks like you are addressing sprc and sds functions in #149, so in that case this PR is ready for review and merge

@njtierney
Copy link
Owner

OK great! Sorry I missed this in #149 - this makes everything easier now, thanks for writing this! :)

@njtierney njtierney merged commit fe72cf4 into njtierney:master Jan 20, 2025
7 checks passed
@Aariq Aariq deleted the ropensci-documentation branch January 21, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants