Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Avoid double-loops in _RecursiveMappingView #37

Merged
merged 4 commits into from
Jun 15, 2022
Merged

ENH: Avoid double-loops in _RecursiveMappingView #37

merged 4 commits into from
Jun 15, 2022

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Jun 15, 2022

They're very slow due to the lazy nature of the class, so instead operate via their set-based counterpart.

@BvB93 BvB93 added the enhancement New feature or request label Jun 15, 2022
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #37 (1534bf9) into master (cd0a4cf) will increase coverage by 0.08%.
The diff coverage is 63.79%.

❗ Current head 1534bf9 differs from pull request most recent head 2ed99ac. Consider uploading reports for the commit 2ed99ac to get more accurate results

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   85.36%   85.44%   +0.08%     
==========================================
  Files          18       18              
  Lines        1319     1347      +28     
  Branches      209      208       -1     
==========================================
+ Hits         1126     1151      +25     
+ Misses        152      147       -5     
- Partials       41       49       +8     
Impacted Files Coverage Δ
nanoutils/hdf5_utils.py 83.57% <61.53%> (-13.24%) ⬇️
nanoutils/_lazy_import.py 88.99% <83.33%> (+11.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0a4cf...2ed99ac. Read the comment docs.

They're very slow due to the lazy nature of the class, so instead operate via their `set`-based counterpart.
@BvB93 BvB93 force-pushed the h5py branch 2 times, most recently from 48adb39 to 6ff778e Compare June 15, 2022 14:41
@BvB93 BvB93 merged commit b6f24b3 into master Jun 15, 2022
@BvB93 BvB93 deleted the h5py branch June 15, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant