Add --use-attention-mask for tp8 as workaround for sharded compilation #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Signed-off-by: aviator19941 <avinash.sharma@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to have a small tweak to how we export for sharding, specifically when exporting we need to include
--use-attention-mask. This is due to some affinity analysis and cloning work that still needs to be worked out. Its the main reason compilation work on iree presubmits. There are plans to get a proper fix in but it will be a while before someone can put hands on the issue.