Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remark-lint whitespace rules #978

Merged
merged 5 commits into from
Mar 10, 2021
Merged

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Mar 3, 2021

Add EditorConfig to fix them going forward in IDEs/GitHub web.
Autofix remaining whitespace rules

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber Stamp LGTM

@mhdawson mhdawson merged commit 29681c4 into nodejs:main Mar 10, 2021
@nschonni nschonni deleted the whitespace branch March 10, 2021 21:54
Trott added a commit to Trott/TSC that referenced this pull request Mar 11, 2021
These updates will require either CPC or Foundation Board approval.

Updates in this commit:

* Resolved an internal conflict in the charter where the minimum
  membership was stated to be three members, but a second provision
  provides that no more than one-fourth of the members can be affiliated
  with the same employer. That second requirement is impossible to meet if
  there are only three members. This change resolves that inconsistency by
  increasing the  minimum membership to four.

* Remove the indication that the TSC is responsible for the Charter. The
  Charter comes from the Foundation Board via the CPC. The TSC is not
  self-chartering.

Trivial updates from previous commits that were not run by the board,
but now is a good time to do it:

* The three links in the bottom references were changed from `http` to
  `https` in nodejs#945.

* A superfluous space was removed from the end of a line in
  nodejs#978.
@Trott Trott mentioned this pull request Mar 11, 2021
mhdawson pushed a commit that referenced this pull request May 26, 2021
These updates will require either CPC or Foundation Board approval.

Updates in this commit:

* Resolved an internal conflict in the charter where the minimum
  membership was stated to be three members, but a second provision
  provides that no more than one-fourth of the members can be affiliated
  with the same employer. That second requirement is impossible to meet if
  there are only three members. This change resolves that inconsistency by
  increasing the  minimum membership to four.

* Remove the indication that the TSC is responsible for the Charter. The
  Charter comes from the Foundation Board via the CPC. The TSC is not
  self-chartering.

Trivial updates from previous commits that were not run by the board,
but now is a good time to do it:

* The three links in the bottom references were changed from `http` to
  `https` in #945.

* A superfluous space was removed from the end of a line in
  #978.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants