-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remark-lint whitespace rules #978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
mhdawson
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber Stamp LGTM
Trott
added a commit
to Trott/TSC
that referenced
this pull request
Mar 11, 2021
These updates will require either CPC or Foundation Board approval. Updates in this commit: * Resolved an internal conflict in the charter where the minimum membership was stated to be three members, but a second provision provides that no more than one-fourth of the members can be affiliated with the same employer. That second requirement is impossible to meet if there are only three members. This change resolves that inconsistency by increasing the minimum membership to four. * Remove the indication that the TSC is responsible for the Charter. The Charter comes from the Foundation Board via the CPC. The TSC is not self-chartering. Trivial updates from previous commits that were not run by the board, but now is a good time to do it: * The three links in the bottom references were changed from `http` to `https` in nodejs#945. * A superfluous space was removed from the end of a line in nodejs#978.
Merged
mhdawson
pushed a commit
that referenced
this pull request
May 26, 2021
These updates will require either CPC or Foundation Board approval. Updates in this commit: * Resolved an internal conflict in the charter where the minimum membership was stated to be three members, but a second provision provides that no more than one-fourth of the members can be affiliated with the same employer. That second requirement is impossible to meet if there are only three members. This change resolves that inconsistency by increasing the minimum membership to four. * Remove the indication that the TSC is responsible for the Charter. The Charter comes from the Foundation Board via the CPC. The TSC is not self-chartering. Trivial updates from previous commits that were not run by the board, but now is a good time to do it: * The three links in the bottom references were changed from `http` to `https` in #945. * A superfluous space was removed from the end of a line in #978.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add EditorConfig to fix them going forward in IDEs/GitHub web.
Autofix remaining whitespace rules