-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible: new centos6 machines, updated & fixed centos6 config #1076
Conversation
opened a PR to allow |
Definitely in favour of just doing in in |
+1 to in ./configure as well. |
So, we set |
I'm not as worried about having to set it for our test machines, but when people checkout/build it would be good if it just worked whenever possible. |
If we're going to be explicit, as much as possible I'd rather we be explicitly saying
It already worked manually if you didn't specify the ARCH, this is just a question of whether it works if you specifically say |
No, unrelated to #1074. We're in a bit of a stale-mate of sorts here, suggestions on how to proceed are welcome. I'd really like to define ARCH and DESTCPU, mainly for the release machines where being explicit is especially important (IMO), and CentOS 6 is now a release machine type. nodejs/node#18052 got merged but that's only on master for now so this is still a problem for everything but master and will be for some time even if we backport it all the way (unlikely for 4.x I reckon). |
For now can we just define it in the job (with a comment that says this can be removed when v4.x goes EoL)? |
New set of CentOS 6 machines. Ansible config didn't quite work for it (I think it was written after deployment and hasn't been used to deploy machines from scratch).
Sadly there's something wrong with the SCL devtoolset-2 repo so I've switched to the centos/tru ones which are unsigned but we can get away without errors on that.