Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 14 to test matrix, update electron versions #889

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Apr 21, 2020

Welcome Node 14. I think it should work out of the box as adaptions for v8 8.1 have been done already in #888.

@Flarna
Copy link
Member Author

Flarna commented Apr 21, 2020

Seems there are some more adaptions needed as there are deprecation warnings.

@Flarna Flarna changed the title Add Node 14 to test matrix, update electron versions WIP: Add Node 14 to test matrix, update electron versions Apr 21, 2020
@kkoopa kkoopa merged commit e14c4e4 into nodejs:master Apr 21, 2020
@kkoopa
Copy link
Collaborator

kkoopa commented Apr 21, 2020

I shall try and have a look at the warnings.

@kkoopa
Copy link
Collaborator

kkoopa commented Apr 21, 2020

I did not see any deprecation warnings in the logs from the CI. Just warnings about the attribute deprecated not being recognized originating upstream.

@Flarna Flarna changed the title WIP: Add Node 14 to test matrix, update electron versions Add Node 14 to test matrix, update electron versions Apr 21, 2020
@Flarna
Copy link
Member Author

Flarna commented Apr 21, 2020

Correct, I misinterpreted this. Maybe a newer compiler should be used for node 13 onwards.

Would be nice to get a nan release which includes node 14 support.

@Flarna Flarna deleted the add-node--14 branch April 21, 2020 18:39
@kkoopa
Copy link
Collaborator

kkoopa commented Apr 21, 2020

Right, probably it wants a newer compiler. Did not get any warnings on Node 13 when testing locally. I shall publish a new version tonight.

@Flarna
Copy link
Member Author

Flarna commented Apr 21, 2020

https://github.com/nodejs/node/blob/v14.0.0/BUILDING.md tells that at least GCC 6.3 is needed and VS2017 on windows. So it works better as expected as here still 4.8 is used which was Node 4 as far as I remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants