Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix four cpplint issues #991

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix four cpplint issues #991

wants to merge 3 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 3, 2025 •
edited
Loading

Fix three cpplint issues:

  1. build/include --> build/include_subdir
  2. build/include_what_you_use
  3. whitespace/blank_line
  4. whitespace/line_length by setting line-length=88

@cclauss cclauss changed the title Fix a couple of cpplint issues Fix a few of cpplint issues Mar 4, 2025
@cclauss cclauss changed the title Fix a few of cpplint issues Fix three cpplint issues Mar 4, 2025
@cclauss cclauss changed the title Fix three cpplint issues Fix four cpplint issues Mar 4, 2025
@cclauss cclauss mentioned this pull request Mar 6, 2025
Merged
@cclauss
Copy link
Contributor Author

cclauss commented Mar 13, 2025

@kkoopa @agracio Your reviews, please.

@agracio
Copy link

agracio commented Mar 13, 2025 •
edited
Loading

I am not a member of nan team
I only participate in topics that are related to Electron builds 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @agracio