Skip to content

Commit 405ae19

Browse files
committedMar 18, 2020
tools: update V8 gypfiles for 8.1
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl> Co-authored-by: Michaël Zasso <targos@protonmail.com> Co-authored-by: Richard Lau <riclau@uk.ibm.com> Co-authored-by: Ujjwal Sharma <ryzokuken@igalia.com> PR-URL: #32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 339c192 commit 405ae19

File tree

4 files changed

+141
-123
lines changed

4 files changed

+141
-123
lines changed
 

‎node.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
}],
7171
[ 'node_use_bundled_v8=="true"', {
7272
'dependencies': [
73-
'tools/v8_gypfiles/v8.gyp:v8_maybe_snapshot',
73+
'tools/v8_gypfiles/v8.gyp:v8_snapshot',
7474
'tools/v8_gypfiles/v8.gyp:v8_libplatform',
7575
],
7676
}],

‎tools/v8_gypfiles/features.gypi

+8-7
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,6 @@
109109
# Enable fast mksnapshot runs.
110110
'v8_enable_fast_mksnapshot%': 0,
111111

112-
# Enable embedded builtins.
113-
'v8_enable_embedded_builtins%': 1,
114-
115112
# Enable the registration of unwinding info for Windows/x64 and ARM64.
116113
'v8_win64_unwinding_info%': 1,
117114

@@ -129,7 +126,7 @@
129126

130127
# Enable pointer compression (sets -dV8_COMPRESS_POINTERS).
131128
'v8_enable_pointer_compression%': 0,
132-
'v8_enable_31bit_smis_on_64bit_arch%': 0,
129+
'v8_enable_31bit_smis_on_64bit_arch%': 1,
133130

134131
# Sets -dOBJECT_PRINT.
135132
'v8_enable_object_print%': 0,
@@ -149,6 +146,9 @@
149146
# Sets -dV8_CONCURRENT_MARKING
150147
'v8_enable_concurrent_marking%': 1,
151148

149+
# Sets -dV8_ARRAY_BUFFER_EXTENSION
150+
'v8_enable_array_buffer_extension%': 0,
151+
152152
# Enables various testing features.
153153
'v8_enable_test_features%': 0,
154154

@@ -295,15 +295,15 @@
295295
['v8_enable_concurrent_marking==1', {
296296
'defines': ['V8_CONCURRENT_MARKING',],
297297
}],
298+
['v8_enable_array_buffer_extension==1', {
299+
'defines': ['V8_ARRAY_BUFFER_EXTENSION',],
300+
}],
298301
['v8_enable_lazy_source_positions==1', {
299302
'defines': ['V8_ENABLE_LAZY_SOURCE_POSITIONS',],
300303
}],
301304
['v8_check_microtasks_scopes_consistency==1', {
302305
'defines': ['V8_CHECK_MICROTASKS_SCOPES_CONSISTENCY',],
303306
}],
304-
['v8_enable_embedded_builtins==1', {
305-
'defines': ['V8_EMBEDDED_BUILTINS',],
306-
}],
307307
['v8_use_siphash==1', {
308308
'defines': ['V8_USE_SIPHASH',],
309309
}],
@@ -327,6 +327,7 @@
327327
}],
328328
], # conditions
329329
'defines': [
330+
'V8_EMBEDDED_BUILTINS',
330331
'V8_GYP_BUILD',
331332
'V8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=<(v8_typed_array_max_size_in_heap)',
332333
], # defines

‎tools/v8_gypfiles/inspector.gypi

+17-11
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@
8686
'<(V8_ROOT)/src/inspector/v8-heap-profiler-agent-impl.h',
8787
'<(V8_ROOT)/src/inspector/v8-inspector-impl.cc',
8888
'<(V8_ROOT)/src/inspector/v8-inspector-impl.h',
89-
'<(V8_ROOT)/src/inspector/v8-inspector-protocol-encoding.cc',
90-
'<(V8_ROOT)/src/inspector/v8-inspector-protocol-encoding.h',
9189
'<(V8_ROOT)/src/inspector/v8-inspector-session-impl.cc',
9290
'<(V8_ROOT)/src/inspector/v8-inspector-session-impl.h',
9391
'<(V8_ROOT)/src/inspector/v8-profiler-agent-impl.cc',
@@ -104,18 +102,26 @@
104102
'<(V8_ROOT)/src/inspector/v8-value-utils.h',
105103
'<(V8_ROOT)/src/inspector/value-mirror.cc',
106104
'<(V8_ROOT)/src/inspector/value-mirror.h',
107-
'<(V8_ROOT)/src/inspector/wasm-translation.cc',
108-
'<(V8_ROOT)/src/inspector/wasm-translation.h',
109105
# Flat merge `third_party/inspector_protocol:inspector_string_conversions`
110106
'<(inspector_path)/v8-string-conversions.cc',
111107
'<(inspector_path)/v8-string-conversions.h',
112-
# Flat merge `third_party/inspector_protocol:encoding`
113-
'<(inspector_protocol_path)/encoding/encoding.cc',
114-
'<(inspector_protocol_path)/encoding/encoding.h',
115-
# Flat merge `third_party/inspector_protocol:bindings`
116-
'<(inspector_protocol_path)/bindings/bindings.cc',
117-
'<(inspector_protocol_path)/bindings/bindings.h',
118-
108+
# Flat merge `third_party/inspector_protocal:crdtp_platform`
109+
'<(inspector_protocol_path)/crdtp/json_platform.h',
110+
'<(inspector_protocol_path)/crdtp/json_platform_v8.cc',
111+
# Flat merge `third_party/inspector_protocol:crdtp`
112+
'<(inspector_protocol_path)/crdtp/cbor.cc',
113+
'<(inspector_protocol_path)/crdtp/cbor.h',
114+
'<(inspector_protocol_path)/crdtp/export.h',
115+
'<(inspector_protocol_path)/crdtp/glue.h',
116+
'<(inspector_protocol_path)/crdtp/json.cc',
117+
'<(inspector_protocol_path)/crdtp/json.h',
118+
'<(inspector_protocol_path)/crdtp/parser_handler.h',
119+
'<(inspector_protocol_path)/crdtp/serializable.cc',
120+
'<(inspector_protocol_path)/crdtp/serializable.h',
121+
'<(inspector_protocol_path)/crdtp/serializer_traits.h',
122+
'<(inspector_protocol_path)/crdtp/span.h',
123+
'<(inspector_protocol_path)/crdtp/status.cc',
124+
'<(inspector_protocol_path)/crdtp/status.h',
119125
],
120126
'v8_inspector_js_protocol': '<(V8_ROOT)/include/js_protocol.pdl',
121127
},

0 commit comments

Comments
 (0)