Skip to content

Commit 7a4beaa

Browse files
joyeecheungRafaelGSS
authored andcommitted
deps: V8: cherry-pick 215ccd593edb
Original commit message: Use FlagValue::value() in SLOW_DCHECK Previously SLOW_DCHECK used the non-constexpr bool() operator of FlagValue, which cannot be used in constexpr. Switch to FlagValue::value() instead for make it compile in constexpr. Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495 Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#86611} Refs: v8/v8@215ccd5 PR-URL: #47212 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 7a2090c commit 7a4beaa

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.14',
39+
'v8_embedder_string': '-node.15',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/common/checks.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
#ifdef ENABLE_SLOW_DCHECKS
1717
#define SLOW_DCHECK(condition) \
18-
CHECK(!v8::internal::FLAG_enable_slow_asserts || (condition))
18+
CHECK(!v8::internal::v8_flags.enable_slow_asserts.value() || (condition))
1919
#define SLOW_DCHECK_IMPLIES(lhs, rhs) SLOW_DCHECK(!(lhs) || (rhs))
2020
#else
2121
#define SLOW_DCHECK(condition) ((void)0)

0 commit comments

Comments
 (0)