Skip to content

Commit 86b77f7

Browse files
committed
tools,doc: use V8::DisposePlatform
V8::ShutdownPlatform has been deprecated and does the same. PR-URL: #41610 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 30c4e1d commit 86b77f7

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

doc/api/embedding.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ int main(int argc, char** argv) {
6161
int ret = RunNodeInstance(platform.get(), args, exec_args);
6262

6363
V8::Dispose();
64-
V8::ShutdownPlatform();
64+
V8::DisposePlatform();
6565
return ret;
6666
}
6767
```

test/cctest/node_test_fixture.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class NodeZeroIsolateTestFixture : public ::testing::Test {
9898
while (uv_loop_alive(&current_loop)) {
9999
uv_run(&current_loop, UV_RUN_ONCE);
100100
}
101-
v8::V8::ShutdownPlatform();
101+
v8::V8::DisposePlatform();
102102
CHECK_EQ(0, uv_loop_close(&current_loop));
103103
}
104104

test/embedding/embedtest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ int main(int argc, char** argv) {
4040
int ret = RunNodeInstance(platform.get(), args, exec_args);
4141

4242
V8::Dispose();
43-
V8::ShutdownPlatform();
43+
V8::DisposePlatform();
4444
return ret;
4545
}
4646

tools/code_cache/mkcodecache.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,6 @@ int main(int argc, char* argv[]) {
6868
}
6969
isolate->Dispose();
7070

71-
v8::V8::ShutdownPlatform();
71+
v8::V8::DisposePlatform();
7272
return 0;
7373
}

0 commit comments

Comments
 (0)