Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path.normalize does not work correctly in case of a folder that contains .. as part of its name #14105

Closed
itai-codefresh opened this issue Jul 6, 2017 · 2 comments
Closed

path.normalize does not work correctly in case of a folder that contains .. as part of its name #14105

itai-codefresh opened this issue Jul 6, 2017 · 2 comments
Labels
confirmed-bug Issues with confirmed bugs.

Comments

@itai-codefresh
Copy link

  • 8.0.0:
  • mac:
  • Subsystem:

When using path.normalize with a folder that has '..' at the end of it, it fails to continue parsing the input correctly.

path.normalize('bar/foo../../')
current output: bar/foo../../
desired output: bar
@targos targos added the confirmed-bug Issues with confirmed bugs. label Jul 6, 2017
@targos
Copy link
Member

targos commented Jul 6, 2017 •
edited
Loading

The behavior changed between v5.6.0 and v5.7.0

Edit: this is likely due to 4dae8ca

@targos targos mentioned this issue Jul 6, 2017
Closed
3 tasks
@targos
Copy link
Member

targos commented Jul 6, 2017

Possible fix: #14107

targos added a commit to targos/node that referenced this issue Aug 28, 2017
@targos
path: fix normalize on directories with two dots
092094d 
Fixes: nodejs#14105
@targos targos closed this as completed in b98e8d9 Aug 30, 2017
ghost pushed a commit to ayojs/ayo that referenced this issue Aug 30, 2017
@targos
path: fix normalize on directories with two dots
36e833b 
PR-URL: nodejs/node#14107
Fixes: nodejs/node#14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
ghost pushed a commit to ayojs/ayo that referenced this issue Aug 30, 2017
@targos
path: fix normalize on directories with two dots
4af4eac 
PR-URL: nodejs/node#14107
Fixes: nodejs/node#14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this issue Aug 31, 2017
@targos @cjihrig
path: fix normalize on directories with two dots
90f7cfa 
PR-URL: nodejs#14107
Fixes: nodejs#14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 10, 2017
@targos @MylesBorins
path: fix normalize on directories with two dots
bee6a5e 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 12, 2017
@targos @MylesBorins
path: fix normalize on directories with two dots
29f9101 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 20, 2017
@targos @MylesBorins
path: fix normalize on directories with two dots
bc2115c 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 16, 2017
@targos @MylesBorins
path: fix normalize on directories with two dots
f9d0016 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 25, 2017
@targos @MylesBorins
path: fix normalize on directories with two dots
f87a626 
PR-URL: #14107
Fixes: #14105
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @itai-codefresh