-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky test-crypto-timing-safe-equal-benchmarks #25984
Comments
@nodejs/crypto |
https://ci.nodejs.org/job/node-test-commit-custom-suites/880/default/console test-rackspace-ubuntu1604-x64-1 00:07:31 not ok 62 pummel/test-crypto-timing-safe-equal-benchmarks
00:07:31 ---
00:07:31 duration_ms: 120.98
00:07:31 severity: fail
00:07:31 exitcode: -15
00:07:31 stack: |-
00:07:31 timeout
00:07:31 ... |
Last successful run took 52 seconds. If there's significant randomness involved (which seems possible given that it's crypto), then a two minute timeout might be an expected result from time to time. But I don't actually know. |
Meh, maybe not. Successful results are pretty consistent in duration. 52 seconds, 53 seconds, 52 seconds.... |
Cause is #26229. |
Resetting require.cache() to `Object.create(null)` each time rather than deleting the specific key results in a 10x improvement in running time. Fixes: nodejs#25984 Refs: nodejs#26229
Using `eval()` rather than `require()`'ing a fixture and deleting it from the cache results in a roughtly 10x improvement in running time. Fixes: #25984 Refs: #26229 PR-URL: #26237 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Using `eval()` rather than `require()`'ing a fixture and deleting it from the cache results in a roughtly 10x improvement in running time. Fixes: #25984 Refs: #26229 PR-URL: #26237 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
https://ci.nodejs.org/job/node-test-commit-custom-suites/864/default/console
test-rackspace-ubuntu1604-x64-1
The text was updated successfully, but these errors were encountered: