Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared-libuv is ignored by uvwasi.gyp #39248

Closed
kapouer opened this issue Jul 3, 2021 · 0 comments
Closed

shared-libuv is ignored by uvwasi.gyp #39248

kapouer opened this issue Jul 3, 2021 · 0 comments

Comments

@kapouer
Copy link
Contributor

kapouer commented Jul 3, 2021

  • Version: all versions since deps/uvwasi
  • Platform: all i guess
  • Subsystem: config/build

What steps will reproduce the bug?

./configure --shared-libuv

What is the expected behavior?

Do not build deps/uv, use system shared library.

What do you see instead?

uv.gyp is pulled by uvwasi and deps/uv is built
kapouer added a commit to kapouer/node that referenced this issue Jul 4, 2021
@kapouer
build: uvwasi honours node_shared_libuv

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c1b5978 
Fix nodejs#39248.
@kapouer kapouer mentioned this issue Jul 4, 2021
Closed
targos pushed a commit that referenced this issue Jul 11, 2021
@kapouer @targos
build: uvwasi honours node_shared_libuv

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600
Verified
Learn about vigilant mode
a7cd40e 
Fix #39248.

PR-URL: #39260
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Sep 4, 2021
@kapouer @targos
build: uvwasi honours node_shared_libuv

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600
Verified
Learn about vigilant mode
40e4632 
Fix #39248.

PR-URL: #39260
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: uvwasi honours node_shared_libuv kapouer/node
1 participant
@kapouer