Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose cppgc::CppHeap::CollectStatistics() in v8 module #56533

Closed
Qard opened this issue Jan 9, 2025 · 2 comments · Fixed by #57146
Closed

Expose cppgc::CppHeap::CollectStatistics() in v8 module #56533

Qard opened this issue Jan 9, 2025 · 2 comments · Fixed by #57146
Labels
diag-agenda Issues and PRs to discuss during the meetings of the diagnostics working group. feature request Issues that request new features to be added to Node.js.

Comments

@Qard
Copy link
Member

Qard commented Jan 9, 2025

What is the problem this feature will solve?

Since we've been migrating things to use CppHeap, we have a bunch of extra GC-managed memory which has become a bit less mysterious to V8. This means we can take better advantage of V8 interfaces to get observability into this memory.

What is the feature you are proposing to solve the problem?

It would likely be an easy win to expose CppHeap data via cppgc::CppHeap::CollectStatistics() in the v8 module.

cc @nodejs/diagnostics

What alternatives have you considered?

No response
@Qard Qard added diag-agenda Issues and PRs to discuss during the meetings of the diagnostics working group. feature request Issues that request new features to be added to Node.js. labels Jan 9, 2025
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Node.js feature requests Jan 9, 2025
@RafaelGSS
Copy link
Member

+1 from me

@mhdawson mhdawson mentioned this issue Jan 20, 2025
Open
@mhdawson mhdawson mentioned this issue Feb 10, 2025
Open
@Aditi-1400
Copy link
Contributor

Given the support for this, I'd like to start working on it!

@Aditi-1400 Aditi-1400 mentioned this issue Feb 20, 2025
Merged
aduh95 pushed a commit that referenced this issue Mar 9, 2025
@Aditi-1400 @aduh95
v8: add v8.getCppHeapStatistics() method
8fe6495 
Expose `CppHeap` data via
`cppgc::CppHeap::CollectStatistics()` in the v8 module.

PR-URL: #57146
Fixes: #56533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this issue Mar 9, 2025
@Aditi-1400 @aduh95
v8: add v8.getCppHeapStatistics() method
a22c21c 
Expose `CppHeap` data via
`cppgc::CppHeap::CollectStatistics()` in the v8 module.

PR-URL: #57146
Fixes: #56533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diag-agenda Issues and PRs to discuss during the meetings of the diagnostics working group. feature request Issues that request new features to be added to Node.js.
Projects
Node.js feature requests
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v8: add v8.getCppHeapStatistics() method Aditi-1400/node
3 participants
@Qard @RafaelGSS @Aditi-1400