Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve message for test-domain-http-server failure cases to include actual value #16048

Closed
wants to merge 2 commits into from
Closed

improve message for test-domain-http-server failure cases to include actual value #16048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd010be
test: improved assert.strictEqual message to include actual values
twk-b Oct 6, 2017
78fb133
improve assert failure message in parallel/test-domain-http-server
twk-b Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-domain-http-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const server = http.createServer(function(req, res) {
const data = JSON.stringify(objects[req.url.replace(/[^a-z]/g, '')]);

// this line will throw if you pick an unknown key
assert.notStrictEqual(data, undefined, 'Data should not be undefined');
assert.notStrictEqual(data, undefined);

res.writeHead(200);
res.end(data);
Expand Down