doc: remove undefined reference variable #16106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove undefined reference variable 'common' from http2 API
nodejs-github-bot
added
doc
joyeecheung
approved these changes
Oct 10, 2017
doc/api/http2.md
Outdated
| @@ -1899,7 +1899,9 @@ const req = client.request({ | |||
| ':authority': `localhost:${port}` | |||
| }); | |||
|
|
|||
| req.on('response', common.mustCall()); | |||
| req.on('response', (headers) => { | |||
| console.log(headers[':status']); | |||
There was a problem hiding this comment.
Would be great if this is headers[http2.constants.HTTP2_HEADER_STATUS]
There was a problem hiding this comment.
Hey, thanks for the review. I just made the necessary changes to the line.
Replaced `headers[':status']` with `headers[http2.constants.HTTP2_HEADER_STATUS]`
jasnell
approved these changes
Oct 12, 2017
|
Oops, this is a doc change, doesn't need CI. |
|
Landed in a84e10e, thanks! |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Remove undefined reference variable 'common' from http2 API PR-URL: nodejs/node#16106 Fixes: nodejs/node#16068 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove undefined reference variable 'common' from http2 API
Checklist
Affected core subsystem(s)
doc
Fixes: #16068