Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: note in backport guide about updating tree #16424

Closed
wants to merge 1 commit into from
Closed

meta: note in backport guide about updating tree #16424

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, lts, meta

I am not sure if this is a right thing, please correct me in any way. This is mostly a strawman to save an issue step.

Previously, I've backported PRs only after some weeks after the landing, so in this period I've managed to update my local fork many times. Today I've got a request to backport a PR after just 2 days after the landing. Following the howto steps, I've got this error:

$ git cherry-pick 93d113510d0353d66d72bfd67e338e9ad6031523
fatal: bad object 93d113510d0353d66d72bfd67e338e9ad6031523

It turned out I had not updated my repo during these 2 days. After updating, this error has disappeared.

So maybe this pre-step is worth mentioning for cases of small PRs we now land and backport quicker.

I've just copied the command from COLLABORATOR_GUIDE.md howto, but I am not a git pro, so I may be wrong here.

Sorry for the big diff due to numerating shift.

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. lts Issues and PRs related to Long Term Support releases. meta Issues and PRs related to the general management of the project. labels Oct 24, 2017
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 24, 2017
@vsemozhetbyt vsemozhetbyt deleted the doc-bp-sync branch October 27, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. lts Issues and PRs related to Long Term Support releases. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants