Enhance Cipher, Decipher coverage #17449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Dec 4, 2017
| const Decipher = crypto.Decipher; | ||
| const instance = crypto.Decipher('aes-256-cbc', 'secret'); | ||
| assert(instance instanceof Decipher, 'Decipher is expected to return a new ' + | ||
| 'instance when called without `new`'); |
There was a problem hiding this comment.
I made a silly mistake.
I'll fix it soon.
|
Same deal as #17458 (comment), are we able to use the |
maclover7
approved these changes
Dec 5, 2017
| @@ -70,6 +70,81 @@ testCipher1(Buffer.from('MySecretKey123')); | |||
| testCipher2('0123456789abcdef'); | |||
| testCipher2(Buffer.from('0123456789abcdef')); | |||
|
|
|||
| { | |||
| const Cipher = crypto.Cipher; | |||
| const instance = crypto.Cipher('aes-256-cbc', 'secret'); | |||
There was a problem hiding this comment.
Same adobe #17458 (comment)
|
|
||
| { | ||
| const Decipher = crypto.Decipher; | ||
| const instance = crypto.Decipher('aes-256-cbc', 'secret'); |
jasnell
approved these changes
Dec 5, 2017
BridgeAR
approved these changes
Dec 6, 2017
maclover7
approved these changes
Dec 7, 2017
maclover7
added
the
author ready
|
Landed in 84b7a86 |
apapirovski
pushed a commit
that referenced
this pull request
Dec 8, 2017
Cipher - Call constructor withour new keyword - Call constructor with cipher is not string - Call constructor with cipher is string and password is not string - Call Cipher#update with data is not string - Call Cipher#setAuthTag with tagbuf is not string - Call Cipher#setAAD with aadbuf is not string Decipher - Call constructor withour new keyword - Call constructor with cipher is not string - Call constructor with cipher is string and password is not string PR-URL: #17449 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
These tests rely on the semver major changes in #16527 |
addaleax
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added those test:
Cipher
Cipher#updatewith data is not stringCipher#setAuthTagwith tagbuf is not stringCipher#setAADwith aadbuf is not stringDecipher
Current coverage is here: https://coverage.nodejs.org/coverage-06e1b0386196f8f8/root/internal/crypto/cipher.js.html
CipherivandDecipherivis not covered in this PR to avoid PR too large.I'm going to write these test in another PR.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test