Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests into internal/crypto/random.js to improve coverage #17555

Closed
wants to merge 4 commits into from
+19 −0
Closed

Add tests into internal/crypto/random.js to improve coverage #17555

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
512f34f
test: add test case where call randomFill with argument cb is not a f…
Leko Dec 8, 2017
16b4677
test: test: add test case where call randomBytes with cb is not a fun…
Leko Dec 8, 2017
c1ffcfb
test: update test to check various invalid callback types
Leko Dec 9, 2017
ded1097
test: Move crypto.randomBytes test to inside the new forEach loop
Leko Dec 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/parallel/test-crypto-random.js
View file
Original file line number Diff line number Diff line change
@@ -119,6 +119,17 @@ process.setMaxListeners(256);
assert.notStrictEqual(before, after);
}

{
const buf = Buffer.alloc(10);
common.expectsError(
() => crypto.randomFill(buf, 0, 10, null),
{
code: 'ERR_INVALID_CALLBACK',
type: TypeError,
message: 'Callback must be a function',
});
}

{
const buf = Buffer.alloc(10);
const before = buf.toString('hex');
@@ -487,6 +498,15 @@ common.expectsError(
}
);

common.expectsError(
() => crypto.randomBytes(1, null),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this also be put inside the forEach loop? Or have a new forEach loop around it? Then we're good to go. :)

Copy link
Contributor Author

@Leko Leko Dec 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it to inside the new forEach loop to omit undefined in test case.

function randomBytes(size, cb) {
  assertSize(size);
  Iif (cb !== undefined && typeof cb !== 'function') // <- undefined is omitted
    throw new errors.TypeError('ERR_INVALID_CALLBACK');

{
code: 'ERR_INVALID_CALLBACK',
type: TypeError,
message: 'Callback must be a function',
}
);

[1, true, NaN, null, undefined, {}, []].forEach((i) => {
common.expectsError(
() => crypto.randomFillSync(i),