Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child-process: support any shells on Windows #21943

Closed
wants to merge 16 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix exec-any-shell test for powershell
When giving 'echo foo bar' to powershell,
 the result contains a new line like:
foo
bar

This commit enables to test with poweshell correctly.
tkamenoko authored and joaocgreis committed Sep 1, 2018
commit 6b9b090d6914b9555ce2f3e22b0a62d8c8aa7c06
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ if (!common.isWindows)
const test = (shell) => {
cp.exec('echo foo bar', { shell: shell }, (error, stdout, stderror) => {
assert.ok(!error && !stderror);
assert.ok(stdout.startsWith('foo bar'));
assert.ok(stdout.includes('foo') && stdout.includes('bar'));
});
};