Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] v8 bug fixes for s390x #22375

Closed
wants to merge 1 commit into from
+19 −7
Closed

[8.x] v8 bug fixes for s390x #22375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 6
#define V8_MINOR_VERSION 2
#define V8_BUILD_NUMBER 414
#define V8_PATCH_LEVEL 65
#define V8_PATCH_LEVEL 66

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
12 changes: 6 additions & 6 deletions deps/v8/src/compiler/s390/instruction-selector-s390.cc
View file
Original file line number Diff line number Diff line change
@@ -318,12 +318,12 @@ ArchOpcode SelectLoadOpcode(Node* node) {
/* Float unary op*/ \
V(BitcastFloat32ToInt32) \
/* V(TruncateFloat64ToWord32) */ \
/* V(RoundFloat64ToInt32) */ \
/* V(TruncateFloat32ToInt32) */ \
/* V(TruncateFloat32ToUint32) */ \
/* V(TruncateFloat64ToUint32) */ \
/* V(ChangeFloat64ToInt32) */ \
/* V(ChangeFloat64ToUint32) */ \
V(RoundFloat64ToInt32) \
V(TruncateFloat32ToInt32) \
V(TruncateFloat32ToUint32) \
V(TruncateFloat64ToUint32) \
V(ChangeFloat64ToInt32) \
V(ChangeFloat64ToUint32) \
/* Word32 unary op */ \
V(Word32Clz) \
V(Word32Popcnt) \
12 changes: 12 additions & 0 deletions deps/v8/src/s390/macro-assembler-s390.cc
View file
Original file line number Diff line number Diff line change
@@ -704,6 +704,9 @@ void TurboAssembler::ConvertDoubleToInt32(const Register dst,
UNIMPLEMENTED();
break;
}
#ifdef V8_TARGET_ARCH_S390X
lghi(dst, Operand::Zero());
#endif
cfdbr(m, dst, double_input);
}

@@ -728,6 +731,9 @@ void TurboAssembler::ConvertFloat32ToInt32(const Register result,
UNIMPLEMENTED();
break;
}
#ifdef V8_TARGET_ARCH_S390X
lghi(result, Operand::Zero());
#endif
cfebr(m, result, double_input);
}

@@ -752,6 +758,9 @@ void TurboAssembler::ConvertFloat32ToUnsignedInt32(
UNIMPLEMENTED();
break;
}
#ifdef V8_TARGET_ARCH_S390X
lghi(result, Operand::Zero());
#endif
clfebr(m, Condition(0), result, double_input);
}

@@ -824,6 +833,9 @@ void TurboAssembler::ConvertDoubleToUnsignedInt32(
UNIMPLEMENTED();
break;
}
#ifdef V8_TARGET_ARCH_S390X
lghi(dst, Operand::Zero());
#endif
clfdbr(m, Condition(0), dst, double_input);
}