Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove skip of OS X bug #22546

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove skip of OS X bug
Three tests are skipped because of Applie bug 17894467. That bug exists
in OS X 10.10, but we no longer support 10.10 (and neither does Apple).
Remove the test-skipping.
Trott committed Aug 27, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
commit f6ffe45b60d125d8474f9145ddb28e755d6b085d
3 changes: 0 additions & 3 deletions test/parallel/test-dgram-send-empty-array.js
Original file line number Diff line number Diff line change
@@ -2,9 +2,6 @@

const common = require('../common');

if (common.isOSX)
common.skip('because of 17894467 Apple bug');

const assert = require('assert');
const dgram = require('dgram');

2 changes: 0 additions & 2 deletions test/parallel/test-dgram-send-empty-buffer.js
Original file line number Diff line number Diff line change
@@ -21,8 +21,6 @@

'use strict';
const common = require('../common');
if (common.isOSX)
common.skip('because of 17894467 Apple bug');

const assert = require('assert');
const dgram = require('dgram');
2 changes: 0 additions & 2 deletions test/parallel/test-dgram-send-empty-packet.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
'use strict';
const common = require('../common');
if (common.isOSX)
common.skip('because of 17894467 Apple bug');

const assert = require('assert');
const dgram = require('dgram');