Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: deprecate passing falsy hostname to dns.lookup #23173

Closed
wants to merge 7 commits into from
Closed

dns: deprecate passing falsy hostname to dns.lookup #23173

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0ae969f
dns: deprecate passing falsy hostname to dns.lookup
oyyd Sep 30, 2018
197af1c
dns: add deprecation code and fix tests
oyyd Sep 30, 2018
8b0fcee
dns: replace the deprecation number with a temporal placeholder
oyyd Sep 30, 2018
69a614f
dns: only emit warning once
oyyd Sep 30, 2018
b73cc6d
dns: fix doc typo
oyyd Oct 1, 2018
e96c0a6
dns: fix doc typo
oyyd Oct 1, 2018
a712c0a
dns: fix doc typo
oyyd Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
dns: fix doc typo
  • Loading branch information
@oyyd
oyyd committed Oct 2, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9
Expired
Verified
Learn about vigilant mode
commit a712c0a0ef41857d0a5dd33e15e5aa5f200fcdf1
8 changes: 4 additions & 4 deletions doc/api/deprecations.md
View file
Original file line number Diff line number Diff line change
@@ -2215,7 +2215,7 @@ Using the `_handle` property to access the native object is deprecated because
improper use of the native object can lead to crashing the application.

<a id="DEP0XXX"></a>
### DEP0XXX: dns.lookup() supports for a falsy hostname
### DEP0XXX: dns.lookup() support for a falsy hostname
<!-- YAML
changes:
- version: REPLACEME
@@ -2226,9 +2226,9 @@ changes:
Type: Runtime

Previous versions of Node.js supported `dns.lookup()` with a falsy hostname
like `dns.lookup(false)` due to backward compatibility long before.
This behavior is undocumented and seems useless in real world apps. We
might make passing invalid hostname throw in the future.
like `dns.lookup(false)` due to backward compatibility.
This behavior is undocumented and is thought to be unused in real world apps.
It will become an error in future versions of Node.js.

[`--pending-deprecation`]: cli.html#cli_pending_deprecation
[`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size