Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: switch order of assertion arguments #23563

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: switch order of assertion arguments
this updates the arguments in order to give the actual
return value first and the given expected value second.
zzidante committed Oct 12, 2018
commit 03732a62f6bef6254755ca78d5c6320cefab5ce1
4 changes: 2 additions & 2 deletions test/parallel/test-http-client-get-url.js
Original file line number Diff line number Diff line change
@@ -28,8 +28,8 @@ const URL = url.URL;
const testPath = '/foo?bar';

const server = http.createServer(common.mustCall((req, res) => {
assert.strictEqual('GET', req.method);
assert.strictEqual(testPath, req.url);
assert.strictEqual(req.method, 'GET');
assert.strictEqual(req.url, testPath);
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.write('hello\n');
res.end();