Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x] http: fix backport of Slowris headers #24796

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
http: fix backport of Slowloris headers
The backport of 618eebdd17 was
not complete, and the starting time to parse the headers was not reset.

Fixes: #24760
mcollina committed Dec 3, 2018
commit 4341817d1460d82fde81858b3d92915cf20c8d37
3 changes: 3 additions & 0 deletions lib/_http_server.js
Original file line number Diff line number Diff line change
@@ -481,6 +481,9 @@ function connectionListener(socket) {
function parserOnIncoming(req, shouldKeepAlive) {
incoming.push(req);

// Set to zero to communicate that we have finished parsing.
socket.parser.parsingHeadersStart = 0;

// If the writable end isn't consuming, then stop reading
// so that we don't become overwhelmed by a flood of
// pipelined requests that may never be resolved.