Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: move inner classes of Environment out for readability #26824

Closed
wants to merge 8 commits into from
+215 −229
Closed

src: move inner classes of Environment out for readability #26824

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7b0bbaf
src: move AsyncHooks out of Environment
joyeecheung Mar 20, 2019
1a311a5
src: move AsyncCallbackScope out of Environment
joyeecheung Mar 20, 2019
c827efd
src: move ImmediateInfo out of Environment
joyeecheung Mar 20, 2019
d8ad2f0
src: move TickInfo out of Environment
joyeecheung Mar 20, 2019
3a28707
src: move TrackingTraceStateObserver out of Environment
joyeecheung Mar 20, 2019
be197ca
src: move ShouldNotAbortOnUncaughtScope out of Environment
joyeecheung Mar 20, 2019
b3ba085
fixup! src: move ShouldNotAbortOnUncaughtScope out of Environment
joyeecheung Mar 22, 2019
8b9d63a
fixup! fixup! src: move ShouldNotAbortOnUncaughtScope out of Environment
joyeecheung Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! src: move ShouldNotAbortOnUncaughtScope out of Environment
@joyeecheung
joyeecheung committed Mar 22, 2019

Verified

This commit was signed with the committer’s verified signature.
joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D
Verified
Learn about vigilant mode
commit b3ba0852c80160b556cabc368c4d2a6b0bdfbd26
2 changes: 1 addition & 1 deletion src/env.h
View file
Original file line number Diff line number Diff line change
@@ -680,7 +680,7 @@ class TrackingTraceStateObserver :
};

class ShouldNotAbortOnUncaughtScope {
public:
public:
explicit inline ShouldNotAbortOnUncaughtScope(Environment* env);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like forget to format this class ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

inline void Close();
inline ~ShouldNotAbortOnUncaughtScope();