Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.x reverts #31782

Closed
wants to merge 6 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "build: re-introduce --use-largepages as no-op"
This reverts commit 5fcf542.
MylesBorins committed Feb 13, 2020

Unverified

The email in this signature doesn’t match the committer email.
commit 5ab784639d54bb46b48602828a7cd9e5940cf496
10 changes: 0 additions & 10 deletions configure.py
Original file line number Diff line number Diff line change
@@ -398,16 +398,6 @@
dest='with_etw',
help='build with ETW (default is true on Windows)')

parser.add_option('--use-largepages',
action='store_true',
dest='node_use_large_pages',
help='This option has no effect. --use-largepages is now a runtime option.')

parser.add_option('--use-largepages-script-lld',
action='store_true',
dest='node_use_large_pages_script_lld',
help='This option has no effect. --use-largepages is now a runtime option.')

intl_optgroup.add_option('--with-intl',
action='store',
dest='with_intl',