module: fix Windows folder exports deprecation warning #36859
Merged
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
approved these changes
Jan 10, 2021
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jan 10, 2021
GeoffreyBooth
approved these changes
Jan 11, 2021
MylesBorins
approved these changes
Jan 11, 2021
PR-URL: nodejs#36859 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
aduh95
force-pushed
the
subpath-deprecation-win-fix
branch
from
6daadf1 to
2e909c4
Compare
|
Landed in 2e909c4 |
danielleadams
pushed a commit
that referenced
this pull request
Jan 13, 2021
PR-URL: #36859 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the deprecation warning introduced in #35747 which was triggering incorrectly for third-party package resolutions in Windows.
Should have tested the negative case fully, but at least it has made people aware of the deprecation who have been using Node.js 15.
An alternative might be to just go ahead and apply this warning for all resolutions anyway, but let's stick to the plan of a slow deprecation for now at least.
@nodejs/modules