Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid compiling with VS v17.12 #55930

Merged
merged 1 commit into from
Nov 26, 2024
+10 −1
Merged

build: avoid compiling with VS v17.12 #55930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion vcbuild.bat
View file
Original file line number Diff line number Diff line change
@@ -292,10 +292,19 @@ goto exit
@rem Visual Studio v17.10 has a bug that causes the build to fail.
@rem Check if the version is v17.10 and exit if it is.
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
if %errorlevel% neq 1 (
if %errorlevel% neq 1 (
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
goto exit
)
@rem Same applies to v17.12 for MSVC.
echo %VSCMD_VER% | findstr /b /c:"17.12" >nul
if %errorlevel% neq 1 (
@rem Clang 18.1.8 Provided with VS 17.12 works fine.
if not defined clang_cl (
echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including a link to an issue that describes the reason for this would be helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jasnell thanks for the suggestion. That makes a lot of sense. However, you've already approved this, the CI has finished, and based on the MSFT issue the reason behind it is fixed and pending release. I assume this will be in some 17.12.x release, so I'll most likely end up reverting this then. With all that in mind, would you oppose me landing this PR as is?

goto exit
)
)

@rem check if the clang-cl build is requested
if not defined clang_cl goto clang-skip