Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove redundant qualifiers in src/quic #56967

Merged

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 8, 2025

Removes redundant qualifiers in src/quic folder. cc @jasnell

@anonrig anonrig requested a review from jasnell February 8, 2025 21:50
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (8342183) to head (2429f34).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56967   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files         630      630           
  Lines      185195   185195           
  Branches    36249    36246    -3     
=======================================
+ Hits       167036   167040    +4     
- Misses      11132    11140    +8     
+ Partials     7027     7015   -12     

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 10, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@anonrig anonrig force-pushed the yagiz/remove-redundant-qualifiers branch from 71dd030 to 2429f34 Compare March 5, 2025 21:49
@nodejs-github-bot
Copy link
Collaborator

@anonrig anonrig requested review from jasnell and targos March 5, 2025 21:51
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these aren't actually going to be tested in CI right now given the addition of the new compile flag. But otherwise LGTM

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 6, 2025
@nodejs-github-bot nodejs-github-bot merged commit 3483937 into nodejs:main Mar 6, 2025
54 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3483937

@richardlau
Copy link
Member

Note that these aren't actually going to be tested in CI right now given the addition of the new compile flag. But otherwise LGTM

FWIW there's node-test-commit-linux-quic which anyone can run. It's not run automatically on PR's (#57301 (comment) indicated not to waste effort on preserving the quictls stuff so I've not done anything else with the job but it's still there if anyone needs it).

aduh95 pushed a commit that referenced this pull request Mar 9, 2025
PR-URL: #56967
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Mar 9, 2025
PR-URL: #56967
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants