-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove redundant qualifiers in src/quic #56967
src: remove redundant qualifiers in src/quic #56967
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56967 +/- ##
=======================================
Coverage 90.19% 90.19%
=======================================
Files 630 630
Lines 185195 185195
Branches 36249 36246 -3
=======================================
+ Hits 167036 167040 +4
- Misses 11132 11140 +8
+ Partials 7027 7015 -12 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
71dd030
to
2429f34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these aren't actually going to be tested in CI right now given the addition of the new compile flag. But otherwise LGTM
Landed in 3483937 |
FWIW there's node-test-commit-linux-quic which anyone can run. It's not run automatically on PR's (#57301 (comment) indicated not to waste effort on preserving the quictls stuff so I've not done anything else with the job but it's still there if anyone needs it). |
PR-URL: #56967 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56967 Reviewed-By: James M Snell <jasnell@gmail.com>
Removes redundant qualifiers in src/quic folder. cc @jasnell