sea: suppress builtin warning with disableExperimentalSEAWarning option #57086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
reviewed
Feb 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57086 +/- ##
==========================================
- Coverage 89.10% 89.09% -0.02%
==========================================
Files 665 665
Lines 193203 193250 +47
Branches 37216 37226 +10
==========================================
+ Hits 172163 172175 +12
- Misses 13767 13805 +38
+ Partials 7273 7270 -3
|
Signed-off-by: koooge <koooooge@gmail.com>
koooge
force-pushed
the
sea-disable-builtin-warning
branch
from
dec12c5 to
42af3be
Compare
joyeecheung
approved these changes
Feb 16, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Feb 16, 2025
github-actions
bot
removed
the
request-ci
jasnell
pushed a commit
that referenced
this pull request
Feb 18, 2025
Signed-off-by: koooge <koooooge@gmail.com> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 6fe0723 |
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
Signed-off-by: koooge <koooooge@gmail.com> PR-URL: nodejs#57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 24, 2025
Signed-off-by: koooge <koooooge@gmail.com> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 25, 2025
Signed-off-by: koooge <koooooge@gmail.com> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: nodejs/single-executable#107