-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: improve urlpattern regexp performance #57136
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
anonrig:yagiz/improve-urlpattern-performance
Feb 21, 2025
Merged
url: improve urlpattern regexp performance #57136
nodejs-github-bot
merged 1 commit into
nodejs:main
from
anonrig:yagiz/improve-urlpattern-performance
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57136 +/- ##
=======================================
Coverage 89.03% 89.03%
=======================================
Files 665 665
Lines 193408 193408
Branches 37279 37273 -6
=======================================
+ Hits 172206 172209 +3
+ Misses 13886 13885 -1
+ Partials 7316 7314 -2
|
mcollina
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pmarchini
approved these changes
Feb 20, 2025
jasnell
approved these changes
Feb 20, 2025
UlisesGascon
approved these changes
Feb 20, 2025
Landed in 9e6a62f |
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#57136 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 24, 2025
PR-URL: #57136 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 25, 2025
PR-URL: #57136 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
review wanted
PRs that need reviews.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @erikcorry's recommendation, we can speed up regexp performance of URLPattern
Benchmarks show no improvement, but I believe that is due to our lack of proper benchmark cases. (we don't have any benchmarks that use *)
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1658