Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in Windows building instructions #57158

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

timja
Copy link
Contributor

@timja timja commented Feb 21, 2025

I tried building node.js on Windows following the instructions and the path to the configurations is wrong:

PS C:\Users\Tim\code\node> winget configure .\configurations\configuration.dsc.yaml
File does not exist: .\configurations\configuration.dsc.yaml
PS C:\Users\Tim\code\node> winget configure .\.configurations\configuration.dsc.yaml
Apply :: WinGetPackage [pythonPackage]

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Feb 21, 2025
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2025
@nodejs-github-bot nodejs-github-bot merged commit 992036e into nodejs:main Feb 24, 2025
17 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 992036e

@timja timja deleted the patch-1 branch February 24, 2025 10:10
targos pushed a commit that referenced this pull request Feb 25, 2025
PR-URL: #57158
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
targos pushed a commit that referenced this pull request Feb 25, 2025
PR-URL: #57158
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants