tools: add more details about rolling inspector_protocol #57167
Merged
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
legendecas
force-pushed
the
doc/inspector-protocol
branch
from
0ee06d9 to
f3d0312
Compare
aduh95
reviewed
Feb 23, 2025
aduh95
reviewed
Feb 23, 2025
aduh95
reviewed
Feb 23, 2025
aduh95
reviewed
Feb 23, 2025
aduh95
reviewed
Feb 23, 2025
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
legendecas
force-pushed
the
doc/inspector-protocol
branch
from
d7218cf to
6cf3fd5
Compare
|
@aduh95 thanks, updated! |
joyeecheung
approved these changes
Mar 4, 2025
|
I can setup an automation as a follow-up. It depends on depot_tools so it may require some effort to set it up in a GitHub action environment. |
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f37d2a5 |
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
PR-URL: #57167 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
PR-URL: #57167 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions on how to run
tools/inspector_tools/roll.py.