test: swap assert.strictEqual() parameters #57217
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `actual` and the `expected` parameters are respectively the first and the second.
nodejs-github-bot
added
needs-ci
targos
approved these changes
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57217 +/- ##
==========================================
- Coverage 90.27% 90.25% -0.02%
==========================================
Files 630 630
Lines 184634 184634
Branches 36128 36120 -8
==========================================
- Hits 166671 166637 -34
- Misses 11020 11034 +14
- Partials 6943 6963 +20 |
aduh95
approved these changes
Feb 26, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
trivikr
approved these changes
Feb 26, 2025
atlowChemi
approved these changes
Feb 26, 2025
jasnell
approved these changes
Feb 26, 2025
|
I can never remember the order on these. The ship has long sailed off into the distance but I would have much preferred an API like... Or something similar that makes it a lot clearer... Ah well, good find. |
|
@jasnell it's never too late for |
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0d92ce4 |
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
The `actual` and the `expected` parameters are respectively the first and the second. PR-URL: #57217 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
actualand theexpectedparameters are respectively the first and the second.