Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing assert return types #57219

Merged
merged 1 commit into from
Feb 28, 2025
Merged

doc: add missing assert return types #57219

merged 1 commit into from
Feb 28, 2025
+2 −0

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 26, 2025

This commit documents the return types for assert.rejects() and assert.doesNotReject().

@cjihrig
doc: add missing assert return types
ee15d13 
This commit documents the return types for assert.rejects() and
assert.doesNotReject().
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Feb 26, 2025
bjohansebas
bjohansebas reviewed Feb 26, 2025
View reviewed changes
Copy link

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atlowChemi atlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2025
@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2025
@nodejs-github-bot nodejs-github-bot merged commit aafc14b into nodejs:main Feb 28, 2025
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in aafc14b

@cjihrig cjihrig deleted the assert branch February 28, 2025 14:40
aduh95 pushed a commit that referenced this pull request Mar 9, 2025
@cjihrig @aduh95
doc: add missing assert return types
b74e0ff 
This commit documents the return types for assert.rejects() and
assert.doesNotReject().

PR-URL: #57219
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjohansebas bjohansebas bjohansebas left review comments

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@aymen94 aymen94 aymen94 approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @jasnell @lpinca @targos @aymen94 @atlowChemi @bjohansebas