build,win: disable node pch with ccache #57224
Merged
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanStojanovic
added
windows
|
Review requested:
|
StefanStojanovic
force-pushed
the
mefi-pch-ccache
branch
from
573f542 to
6d2c9dd
Compare
targos
approved these changes
Feb 27, 2025
StefanStojanovic
added
the
fast-track
|
Fast-track has been requested by @StefanStojanovic. Please 👍 to approve. |
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Feb 27, 2025
richardlau
approved these changes
Feb 27, 2025
StefanStojanovic
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4edc6db |
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
PR-URL: #57224 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the previously landed PR disabling V8 pch when using ClangCL and ccache. The issue here is similar, only not visible in each build (as some V8 files are generated during the build phase).
I've disabled the ClangCL compilation in the CI until this lands as it can block valid PRs from landing. For more details check any failed build here. What you'll find there is that either embedtest.pch or libnode.pch is causing issue, and this change will resolve that.
cc @joyeecheung @nodejs/platform-windows
P.S. I'd also like to use fast-tracking here so that I can reenable the ClangCL compilation in the CI ASAP.